erp5_web_project_ui: initial commit for project.nexedi.net

bt5/erp5_crm/SkinTemplateItem/portal_skins/erp5_crm/Base_generateStateSupportDomain.py

+
+not_validated_domain.edit(title="Not Validated",
+                       criterion_property_list=['simulation_state'])
+not_validated_domain.setCriterion('simulation_state', identity=['submitted', 'suspended', 'draft', 'invalidated'])
+
+domain_list.append(not_validated_domain)
+
+cancelled_domain = parent.generateTempDomain(id='cancelled')
+
+cancelled_domain.edit(title="Cancelled",
+                       criterion_property_list=['simulation_state'])
+cancelled_domain.setCriterion('simulation_state', identity=['cancelled', 'deleted'])
+
+domain_list.append(cancelled_domain)
+
+return domain_list

bt5/erp5_project/SkinTemplateItem/portal_skins/erp5_project/ProjectModule_viewProjectList/listbox.xml

                 </item>
+                <item>
+                    <key> <string>url_columns</string> </key>
+                    <value>
+                      <list>
+                        <tuple>
+                          <string>title</string>
+                          <string>Project_getQuickViewUrl</string>
+                        </tuple>
+                        <tuple>
+                          <string>default_destination_section_title</string>
+                          <string>Project_getQuickViewUrl</string>
+                        </tuple>
+                      </list>
+                    </value>
+                </item>

bt5/erp5_project/SkinTemplateItem/portal_skins/erp5_project/Project_viewMilestone.xml

         </item>
         <item>
             <key> <string>pt</string> </key>
-            <value> <string>form_view</string> </value>
+            <value> <string>form_list</string> </value>

bt5/erp5_web_project_ui/SkinTemplateItem/portal_skins/erp5_web_project/Project_getRenderJSExtraInfoParameterList.py

+"""
+================================================================================
+Return parameters to correctly display the RenderJS gadget
+================================================================================
+"""
+
+return [('project_title', context.getTitle()), ('jio_key', context.getRelativeUrl()),  ('project_reference', context.getReference())]

bt5/erp5_web_project_ui/SkinTemplateItem/portal_skins/erp5_web_project/gadget_project_info.html.html

+      <p>
+        <a id="milestone_link" class="first-line-buttons ui-disabled" data-i18n="[value]Milestones" disabled >Milestones</a>
+        <a id="support_request_link" class="first-line-buttons ui-disabled" data-i18n="[value]Support Requests" disabled >Support requests</a>
+        <a id="bug_link" class="first-line-buttons ui-disabled" data-i18n="[value]Bugs" disabled >Opened Bugs</a>
+        <a id="closed_bug_link" class="first-line-buttons ui-disabled" data-i18n="[value]Closed Bugs" disabled >Closed Bugs</a>
+      </p>
+    </div>
+    <div class="ui-field-contain" style="top:75px;">
+      <p>
+        <a id="task_link" class="first-line-buttons ui-disabled" data-i18n="[value]Confirmed Tasks" disabled >Confirmed Tasks</a>
+        <a id="not_confirmed_task_link" class="first-line-buttons ui-disabled" data-i18n="[value]Not Confirmed Tasks" disabled >Not Confirmed Tasks</a>
+        <a id="report_link" class="first-line-buttons ui-disabled" data-i18n="[value]Task Reports" disabled >Opened Task Reports</a>
+        <a id="closed_report_link" class="first-line-buttons ui-disabled" data-i18n="[value]Closed Task Reports" disabled >Closed Task Reports</a>
+      </p>
+    </div>
+    <div class="ui-field-contain" style="top:125px;">

bt5/erp5_web_project_ui/SkinTemplateItem/portal_skins/erp5_web_project/gadget_project_info.js.js

+/*jslint nomen: true, indent: 2 */
+/*global window, rJS, RSVP, document, FileReader, Blob, jIO, ensureArray,
+lockGadgetInQueue, unlockGadgetInQueue*/

bt5/erp5_web_project_ui/bt/template_path_list

+web_page_module/project_**
+web_site_module/project_nexedi_net

Salut @romain , this MR is ready for review.

I run all tests and this change: rporchetto/erp5@70462354 (form_list header link from #display to #history_previous) makes this test fail: https://nexedijs.erp5.net/#/test_result_module/20191104-73476366/108?uid=2027541975

It seems it also breaks erp5js usability completely, as clicking on the link does nothing on module. More manual checks are needed, and probably a new test to prevent such unexpected regression.

isn't it possible to factorise a bit the code? (lot of duplicated logic inside the script + nearly identical other scripts)

Yes, I refactored it into a short function "generateDomain(id, title, criterion_property, criterion_identity)". This function is used then by all the scripts, so it should be in a common script. Considering that these scripts are in different bts, where do you think is the best location for the common script? I see that all involved bt (for now: crm, forge and project) depends on erp5_base. Is it ok to put the common script there?

the url_columns will break erp5 current usage (this script does not exist in erp5_project and is not desired there)

Then, in order to drop this change here, I should use a new project-list-form right?

Yes. I do not see any other solution for now.

This also breaks erp5_project behaviour.

do you really need a new script? Isn't it possible to set the list in the TALES expression?

It was a more complex script at the beginning, then I moved most of the code into jio requests in js side, so now there isn't need of this script. I'll move it to TALES tab in the form.

I would prefer to not set any style attribute in the HTML. Please update your custom CSS instead.

can you jslint this script? (I expect it to at least complain about the unused lockGadgetInQueue variable)

I don't like the nexedi_net suffix, as this code is commited in erp5 repository, and so, is unrelated to any custom nexedi configuration.

Please find a more generic name.

do you agree with "project_management_net" ?

_net is meaningless too.