Merge branch 'hotfix/sidekick-cron-config' into 'master'

Hotfix for sidekiq-cron being loaded from Settingslogic with defaults on Gitlab EE

This is a followup on https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/2173

See merge request !91

config/initializers/1_settings.rb

@@ -303,16 +303,16 @@ Settings.gravatar['host']         = Settings.get_host_without_www(Settings.grava
 Settings['cron_jobs'] ||= Settingslogic.new({})
 Settings.cron_jobs['stuck_ci_builds_worker'] ||= Settingslogic.new({})
 Settings.cron_jobs['stuck_ci_builds_worker']['cron'] ||= '0 0 * * *'
-Settings.cron_jobs['stuck_ci_builds_worker']['class'] = 'StuckCiBuildsWorker'
+Settings.cron_jobs['stuck_ci_builds_worker']['job_class'] = 'StuckCiBuildsWorker'
 Settings.cron_jobs['historical_data_worker'] ||= Settingslogic.new({})
 Settings.cron_jobs['historical_data_worker']['cron'] ||= '0 12 * * *'
-Settings.cron_jobs['historical_data_worker']['class'] = 'HistoricalDataWorker'
+Settings.cron_jobs['historical_data_worker']['job_class'] = 'HistoricalDataWorker'
 Settings.cron_jobs['update_all_mirrors_worker'] ||= Settingslogic.new({})
 Settings.cron_jobs['update_all_mirrors_worker']['cron'] ||= '0 * * * *'
-Settings.cron_jobs['update_all_mirrors_worker']['class'] = 'UpdateAllMirrorsWorker'
+Settings.cron_jobs['update_all_mirrors_worker']['job_class'] = 'UpdateAllMirrorsWorker'
 Settings.cron_jobs['ldap_sync_worker'] ||= Settingslogic.new({})
 Settings.cron_jobs['ldap_sync_worker']['cron'] ||= '30 1 * * *'
-Settings.cron_jobs['ldap_sync_worker']['class'] = 'LdapSyncWorker'
+Settings.cron_jobs['ldap_sync_worker']['job_class'] = 'LdapSyncWorker'
 
 #
 # GitLab Shell

config/initializers/sidekiq.rb

@@ -19,7 +19,11 @@ Sidekiq.configure_server do |config|
   end
 
   # Sidekiq-cron: load recurring jobs from gitlab.yml
-  Sidekiq::Cron::Job.load_from_hash! Gitlab.config.cron_jobs
+  # UGLY Hack to get nested hash from settingslogic
+  cron_jobs = JSON.parse(Gitlab.config.cron_jobs.to_json)
+  # UGLY hack: Settingslogic doesn't allow 'class' key
+  cron_jobs.each { |k,v| cron_jobs[k]['class'] = cron_jobs[k].delete('job_class') }
+  Sidekiq::Cron::Job.load_from_hash! cron_jobs
 
   # Database pool should be at least `sidekiq_concurrency` + 2
   # For more info, see: https://github.com/mperham/sidekiq/blob/master/4.0-Upgrade.md