From a22646af745aef4f32be600428e8c2aecf9a0954 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9my=20Coutable?= <remy@rymai.me> Date: Tue, 3 Sep 2019 09:09:34 +0200 Subject: [PATCH] Ensure 'build-qa-image' is created for all pipelines except docs & qa MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This also makes 'package-and-qa-manual' created for 'master' because it's a valid use-case to run manual QA on 'master'. Without this change, no pipeline could be created for auto-deploy branches due to the following error: The form contains the following error: package-and-qa-manual: needs 'build-qa-image' Signed-off-by: Rémy Coutable <remy@rymai.me> --- .gitlab/ci/qa.gitlab-ci.yml | 4 ---- .gitlab/ci/review.gitlab-ci.yml | 16 +++++++++++++--- 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/.gitlab/ci/qa.gitlab-ci.yml b/.gitlab/ci/qa.gitlab-ci.yml index ac2a70dda0b..6da28852291 100644 --- a/.gitlab/ci/qa.gitlab-ci.yml +++ b/.gitlab/ci/qa.gitlab-ci.yml @@ -21,10 +21,6 @@ package-and-qa-manual: - .package-and-qa-base - .except-docs-qa when: manual - except: - - master - - /(^docs[\/-].+|.+-docs$)/ - - /(^qa[\/-].*|.*-qa$) package-and-qa: extends: .package-and-qa-base diff --git a/.gitlab/ci/review.gitlab-ci.yml b/.gitlab/ci/review.gitlab-ci.yml index 3415f1b6ab4..360e4433e57 100644 --- a/.gitlab/ci/review.gitlab-ci.yml +++ b/.gitlab/ci/review.gitlab-ci.yml @@ -22,7 +22,9 @@ - source scripts/utils.sh .review-docker: - extends: .review-base + extends: + - .default-tags + - .default-retry image: registry.gitlab.com/gitlab-org/gitlab-build-images:gitlab-qa-alpine services: - docker:19.03.0-dind @@ -36,7 +38,13 @@ QA_IMAGE: "${CI_REGISTRY}/${CI_PROJECT_PATH}/gitlab/${CI_PROJECT_NAME}-qa:${CI_COMMIT_REF_SLUG}" build-qa-image: - extends: .review-docker + extends: + - .review-docker + - .except-docs-qa + only: + refs: + - branches@gitlab-org/gitlab-ce + - branches@gitlab-org/gitlab-ee stage: test script: - time docker build --cache-from ${LATEST_QA_IMAGE} --tag ${QA_IMAGE} --file ./qa/Dockerfile ./ @@ -124,7 +132,9 @@ review-stop: artifacts: {} .review-qa-base: - extends: .review-docker + extends: + - .review-docker + - .review-only retry: 2 stage: qa variables: -- 2.30.9