Merge branch 'winh-ignore-eslint-import-no-cycle' into 'master'

Make import/no-cycle ESLint rule an error

See merge request gitlab-org/gitlab!21110

.eslintrc.yml

@@ -30,7 +30,6 @@ rules:
   no-else-return:
     - error
     - allowElseIf: true
-  import/no-cycle: warn
   import/no-useless-path-segments: off
   import/order: warn
   lines-between-class-members: off

app/assets/javascripts/filtered_search/.eslintrc.yml

+rules:
+  # https://gitlab.com/gitlab-org/gitlab/issues/28716
+  import/no-cycle: off

app/assets/javascripts/ide/.eslintrc.yml

 rules:
+  # https://gitlab.com/gitlab-org/gitlab/issues/28717
+  import/no-cycle: off
   # https://gitlab.com/gitlab-org/gitlab/issues/33024
   promise/no-nesting: off

app/assets/javascripts/image_diff/.eslintrc.yml

+rules:
+  # https://gitlab.com/gitlab-org/gitlab/issues/28719
+  import/no-cycle: off

ee/app/assets/javascripts/filtered_search/.eslintrc.yml

+rules:
+  # https://gitlab.com/gitlab-org/gitlab/issues/28716
+  import/no-cycle: off

ee/app/assets/javascripts/vue_shared/.eslintrc.yml

+rules:
+  # https://gitlab.com/gitlab-org/gitlab/issues/37987
+  import/no-cycle: off