Commit f6399f1d authored by Lin Jen-Shin's avatar Lin Jen-Shin

Merge branch 'danger-throughputs' into 'master'

Danger asks for throughput labels

See merge request gitlab-org/gitlab-ce!30622
parents 4e457ebf 4f72293a
# rubocop:disable Style/SignalException # rubocop:disable Style/SignalException
THROUGHPUT_LABELS = [
'Community contribution',
'security',
'bug',
'feature',
'backstage'
].freeze
if gitlab.mr_body.size < 5 if gitlab.mr_body.size < 5
fail "Please provide a proper merge request description." fail "Please provide a proper merge request description."
end end
...@@ -8,6 +16,10 @@ if gitlab.mr_labels.empty? ...@@ -8,6 +16,10 @@ if gitlab.mr_labels.empty?
fail "Please add labels to this merge request." fail "Please add labels to this merge request."
end end
if (THROUGHPUT_LABELS & gitlab.mr_labels).empty?
warn 'Please add a [throughput label](https://about.gitlab.com/handbook/engineering/management/throughput/#implementation) to this merge request.'
end
unless gitlab.mr_json["assignee"] unless gitlab.mr_json["assignee"]
warn "This merge request does not have any assignee yet. Setting an assignee clarifies who needs to take action on the merge request at any given time." warn "This merge request does not have any assignee yet. Setting an assignee clarifies who needs to take action on the merge request at any given time."
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment