Commit 7a97260f authored by Kirill Smelkov's avatar Kirill Smelkov

NXD Make HTTP to be the default clone protocol

Both fetch and push are possible over https, which is selected by http if
gitlab was configured to use https in external url.

This way to reduce security vectors and possible ways to interact with gitlab
we use https only without ssh at all.
parent e0cdcf81
......@@ -209,6 +209,8 @@ module ProjectsHelper
end
def default_url_to_repo(project = @project)
# always HTTP:
return project.http_url_to_repo
case default_clone_protocol
when 'ssh'
project.ssh_url_to_repo
......@@ -218,8 +220,9 @@ module ProjectsHelper
end
def default_clone_protocol
if !current_user || current_user.require_ssh_key?
gitlab_config.protocol
# always HTTP:
if true # !current_user || current_user.require_ssh_key?
"http"
else
"ssh"
end
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment