Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-workhorse
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-workhorse
Commits
b533f562
Commit
b533f562
authored
Apr 19, 2017
by
Jacob Vosmaer
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Document that we intercept WriteHeader already
parent
0af84341
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
2 additions
and
1 deletion
+2
-1
internal/git/git-http.go
internal/git/git-http.go
+2
-1
No files found.
internal/git/git-http.go
View file @
b533f562
...
@@ -40,7 +40,8 @@ func postRPCHandler(a *api.API, name string, handler func(*GitHttpResponseWriter
...
@@ -40,7 +40,8 @@ func postRPCHandler(a *api.API, name string, handler func(*GitHttpResponseWriter
if
err
:=
handler
(
w
,
r
,
ar
);
err
!=
nil
{
if
err
:=
handler
(
w
,
r
,
ar
);
err
!=
nil
{
// If the handler already wrote a response this WriteHeader call is a
// If the handler already wrote a response this WriteHeader call is a
// (harmless) no-op.
// no-op. It never reaches net/http because GitHttpResponseWriter calls
// WriteHeader on its underlying ResponseWriter at most once.
w
.
WriteHeader
(
500
)
w
.
WriteHeader
(
500
)
helper
.
LogError
(
r
,
fmt
.
Errorf
(
"%s: %v"
,
name
,
err
))
helper
.
LogError
(
r
,
fmt
.
Errorf
(
"%s: %v"
,
name
,
err
))
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment