- 19 Nov, 2019 1 commit
-
-
Hayley Swimelar authored
-
- 11 Nov, 2019 2 commits
-
-
Jacob Vosmaer authored
Upgrade Gitaly client to v1.71.0 Closes #231 See merge request gitlab-org/gitlab-workhorse!439
-
Paul Okstad authored
-
- 05 Nov, 2019 2 commits
-
-
Jacob Vosmaer authored
Ignore CompleteMultipartUpload ETag See merge request gitlab-org/gitlab-workhorse!438
-
Alessio Caiazza authored
Our ETag comparison on CompleteMultipartUpload was based on a reverse engineered protocol. It is not part of the S3 API specification and not every providers compute it in the same way.
-
- 25 Oct, 2019 2 commits
-
-
Jacob Vosmaer authored
Release v8.15.0 See merge request gitlab-org/gitlab-workhorse!437
-
Alessio Caiazza authored
-
- 15 Oct, 2019 3 commits
-
-
Nick Thomas authored
Case insensitive ETag comparison See merge request gitlab-org/gitlab-workhorse!434
-
Alessio Caiazza authored
Some object storage providers returns upcase ETag headers. This commit will perform the check in case insensitive mode
-
Nick Thomas authored
Upgrade gitaly to 1.68.0 See merge request gitlab-org/gitlab-workhorse!435
-
- 14 Oct, 2019 1 commit
-
-
John Cai authored
Gitaly 1.68.0 upgrades GRPC to 1.24.0
-
- 11 Oct, 2019 4 commits
-
-
Jacob Vosmaer authored
Test against go1.13 See merge request gitlab-org/gitlab-workhorse!433
-
Nick Thomas authored
Release v8.14.0 See merge request gitlab-org/gitlab-workhorse!432
-
Nick Thomas authored
-
Nick Thomas authored
-
- 10 Oct, 2019 4 commits
-
-
Nick Thomas authored
Keep HTTP 1.0 cache headers from sendurl proxies See merge request gitlab-org/gitlab-workhorse!431
-
Sean McGivern authored
For maximum compatiblity, the Rails application should also set Date and Pragma, and so we should ensure that these are not overwritten by the object storage provider.
-
Nick Thomas authored
Release v8.13.0 See merge request gitlab-org/gitlab-workhorse!430
-
Nick Thomas authored
-
- 09 Oct, 2019 2 commits
-
-
Nick Thomas authored
Remove test dummy Gitaly RPC handlers See merge request gitlab-org/gitlab-workhorse!429
-
Jacob Vosmaer authored
-
- 07 Oct, 2019 2 commits
-
-
Nick Thomas authored
Preserve original HTTP cache headers in sendurl See merge request gitlab-org/gitlab-workhorse!428
-
Sean McGivern authored
There are a few cases for serving uploads: 1. File storage. Rails asks Workhorse to serve the file. 2. Object storage. Rails redirects (via SendFileUpload) to the object storage host. 2. Object storage with `proxy_download` enabled. Rails asks Workhorse to proxy the download from the object storage host. Rails also sets caching headers for uploads. In case 1, the reverse proxy will keep those headers. In case 2, the headers are whatever the object storage provider sets. Case 3 is changed here. Previously, it would use the cache headers from the object storage provider. Now, it keeps the cache headers from Rails instead. This is better because: 1. Cache headers on the object storage provider can be hard to configure. 2. Even if we ask users to manually configure them, they may get it wrong and inadvertently allow private resources to be cached by proxies. 3. Even if we ask users to manually configure them and they get it right, they will also need to track any updates the Rails application makes to the cache headers it sends. We could solve these by trying to automatically set the metadata policy on the object storage bucket, which would also help with case 2 above. However, that has its own pitfalls. We could, for instance, say that `uploads/-/system/user` is public with an expiry of five minutes, and that's fairly straightforward. But then if we need to update that policy in future to make it public with an expiry of one minute, we are introducing coordination issues. This would get even more complicated if we allowed caching uploads from public projects. If the project's visibility changed, we'd need to update the object storage metadata too. So it's a tricky problem, and this is a relatively small code change to at least solve one case.
-
- 30 Sep, 2019 4 commits
-
-
Jacob Vosmaer authored
Changelog for 8.12.0 See merge request gitlab-org/gitlab-workhorse!426
-
Jacob Vosmaer authored
-
Jacob Vosmaer authored
Fix health checks routes incorrectly intercepting errors See merge request gitlab-org/gitlab-workhorse!424
-
Adrien Kohlbecker authored
-
- 26 Sep, 2019 2 commits
-
-
Nick Thomas authored
Simplify badgateway RoundTripper See merge request gitlab-org/gitlab-workhorse!425
-
Jacob Vosmaer authored
-
- 12 Sep, 2019 6 commits
-
-
Nick Thomas authored
Release v8.11.0 See merge request gitlab-org/gitlab-workhorse!423
-
Nick Thomas authored
-
Nick Thomas authored
Add route for handling Conan package uploads See merge request gitlab-org/gitlab-workhorse!412
-
Steve Abrams authored
Accelerated upload route for conan package files
-
Nick Thomas authored
Accelerate GraphQL uploads See merge request gitlab-org/gitlab-workhorse!403
-
Alessio Caiazza authored
-
- 10 Sep, 2019 1 commit
-
-
Nick Thomas authored
Accelerate wiki attachments See merge request gitlab-org/gitlab-workhorse!422
-
- 05 Sep, 2019 1 commit
-
-
Alessio Caiazza authored
-
- 01 Sep, 2019 3 commits
-
-
Nick Thomas authored
Release workhorse v8.10.0 See merge request gitlab-org/gitlab-workhorse!421
-
Nick Thomas authored
-
Nick Thomas authored
-