• David Teigland's avatar
    dlm: remove extra blocking callback check · 03339696
    David Teigland authored
    Just before delivering a blocking callback (bast), the dlm_astd
    thread checks again that the granted mode of the lkb actually
    blocks the mode requested by the bast.  The idea behind this was
    originally that the granted mode may have changed since the bast
    was queued, making the callback now unnecessary.  Reasons for
    removing this extra check are:
    - dlm_astd doesn't lock the rsb before reading the lkb grmode, so
      it's not technically safe (this removes the long standing FIXME)
    - after running some tests, it doesn't appear the check ever actually
      eliminates a bast
    - delivering an unnecessary blocking callback isn't a bad thing and
      can happen anyway
    Signed-off-by: default avatarDavid Teigland <teigland@redhat.com>
    03339696
ast.c 3.51 KB