• Bhaktipriya Shridhar's avatar
    ps3: Remove deprecated create_singlethread_workqueue · f0200c02
    Bhaktipriya Shridhar authored
    The workqueue "ps3av->wq" queues a single work item &ps3av->work and hence
    doesn't require ordering. It is involved in waking up ps3avd to do the
    video mode setting and hence it's not being used on a memory reclaim
    path. Hence, it has been converted to use system_wq.
    
    System workqueues have been able to handle high level of concurrency
    for a long time now and hence it's not required to have a singlethreaded
    workqueue just to gain concurrency. Unlike a dedicated per-cpu workqueue
    created with create_singlethread_workqueue(), system_wq allows multiple
    work items to overlap executions even on the same CPU; however, a
    per-cpu workqueue doesn't have any CPU locality or global ordering
    guarantee unless the target CPU is explicitly specified and thus the
    increase of local concurrency shouldn't make any difference.
    
    The work item has been flushed in ps3av_remove to ensure that
    there are no pending tasks while disconnecting the driver.
    Signed-off-by: default avatarBhaktipriya Shridhar <bhaktipriya96@gmail.com>
    Acked-by: default avatarTejun Heo <tj@kernel.org>
    Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
    f0200c02
ps3av.c 27.6 KB