• H Hartley Sweeten's avatar
    mtd: sst25l: fix multi-part messages with broken spi masters · 0ffe0ce3
    H Hartley Sweeten authored
    Some SPI masters (ep93xx) have limitations when using the SFRMOUT
    signal for the spi device chip select.  The SFRMOUT signal is
    only asserted as long as the spi transmit fifo contains data.  As
    soon as the last bit is clocked into the receive fifo it gets
    deasserted.
    
    The functions sst25l_status and sst25l_match_device use the API
    function spi_write_then_read to write a command to the flash then
    read the response back.  This API function creates a two part spi
    message for the write then read.  When this message is transferred
    the SFRMOUT signal ends up getting deasserted after the command
    phase.  This causes the command to get aborted by the device so
    the read phase returns invalid data.
    
    By changing sst25l_status and sst25l_match_device to use a single
    transfer synchronous message, the SFRMOUT signal stays asserted
    during the entire message so the correct data always gets returned.
    
    This change will have no effect on SPI masters which use a chip
    select mechanism (GPIO's, etc.) which does stay asserted correctly.
    As a bonus, the single transfer synchronous messages complete faster
    than multi-part messages.
    Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
    Signed-off-by: default avatarDavid Woodhouse <David.Woodhouse@intel.com>
    0ffe0ce3
sst25l.c 11.3 KB