• Arnd Bergmann's avatar
    media: rainshadow-cec: avoid -Wmaybe-uninitialized warning again · 0a0c1b82
    Arnd Bergmann authored
    Back in April I created a patch to address a false-positive warning:
    
    drivers/media/usb/rainshadow-cec/rainshadow-cec.c: In function 'rain_irq_work_handler':
    drivers/media/usb/rainshadow-cec/rainshadow-cec.c:171:31: error: 'data' may be used uninitialized in this function [-Werror=maybe-uninitialized]
    
    My patch was totally wrong and introduced a real bug, and Colin Ian King thankfully
    noticed it now and fixed my mistake. Unfortunately, fixing the actual uninitialized
    data in this case brought back the original bogus warning.
    
    This is a new version of the patch, which simplifies the code to the point where
    gcc notices the behavior is correct.
    
    Fixes: ca33784b ("[media] rainshadow-cec: ensure exit_loop is intialized")
    Fixes: ea6a69de ("[media] rainshadow-cec: avoid -Wmaybe-uninitialized warning")
    
    Cc: Colin Ian King <colin.king@canonical.com>
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Signed-off-by: default avatarHans Verkuil <hansverk@cisco.com>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
    0a0c1b82
rainshadow-cec.c 8.63 KB