• Jean Delvare's avatar
    [PATCH] I2C: Kill i2c_client.id (1/5) · 0e11d70c
    Jean Delvare authored
    (1/5) Stop using i2c_client.id in i2c/chips drivers (mostly hardware
          monitoring drivers).
    
    Drivers affected:
    * adm1021
    * adm1025
    * adm1026
    * adm1031
    * ds1621
    * fscher
    * gl518sm
    * isp1301_omap
    * lm75
    * lm77
    * lm80
    * lm83
    * lm85
    * lm87
    * lm90
    * max1619
    * pcf8574
    * pcf8591
    * rtc8564
    * smsc47m1
    * w83l785ts
    
    The vast majority of these drivers simply defined the i2c_client id
    struct member but never used it, so they are not affected at all by the
    change. Exceptions are:
    
    * lm85 and rtc8564, which would at least display the id in a debug
    message when assigning it. Not really useful though, as the id was then
    never used.
    
    * adm1026, which used the assigned id in all driver messages. However,
    since dev_* calls will append the bus number and client address to these
    messages, the id information is redundant and can go away. Also, the
    driver would allow some GPIO reprogramming on the first client only
    (id=0) and removing the id doesn't allow that anymore. I would restore a
    similar functionality if needed, but the ADM1026 chip is found on very
    few motherboards and none of these has more than one ADM1026 chip AFAIK,
    so it doesn't seem to be worth the effort.
    Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
    Signed-off-by: default avatarGreg Kroah-Hartman <greg@kroah.com>
    0e11d70c
max1619.c 10.4 KB