• Alison Schofield's avatar
    iio: trigger: free trigger resource correctly · 10e840df
    Alison Schofield authored
    These stand-alone trigger drivers were using iio_trigger_put()
    where they should have been using iio_trigger_free().  The
    iio_trigger_put() adds a module_put which is bad since they
    never did a module_get.
    
    In the sysfs driver, module_get/put's are used as triggers are
    added & removed. This extra module_put() occurs on an error path
    in the probe routine (probably rare).
    
    In the bfin-timer & interrupt trigger drivers, the module resources
    are not explicitly managed, so it's doing a put on something that
    was never get'd.  It occurs on the probe error path and on the
    remove path (not so rare).
    
    Tested with the sysfs trigger driver.
    The bfin & interrupt drivers were build tested & inspected only.
    Signed-off-by: default avatarAlison Schofield <amsfield22@gmail.com>
    Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
    10e840df
iio-trig-sysfs.c 4.84 KB