• Robin Murphy's avatar
    drivers: char: mem: Check {read,write}_kmem() addresses · 148a1bc8
    Robin Murphy authored
    Arriving at read_kmem() with an offset representing a bogus kernel
    address (e.g. 0 from a simple "cat /dev/kmem") leads to copy_to_user
    faulting on the kernel-side read.
    
    x86_64 happens to get away with this since the optimised implementation
    uses "rep movs*", thus the user write (which is allowed to fault) and
    the kernel read are the same instruction, the kernel-side fault falls
    into the user-side fixup handler and the chain of events which
    transpires ends up returning an error as one might expect, even if it's
    an inappropriate -EFAULT. On other architectures, though, the read is
    not covered by the fixup entry for the write, and we get a big scary
    "Unable to hande kernel paging request..." dump.
    
    The more typical use-case of mmap_kmem() has always (within living
    memory at least) returned -EIO for addresses which don't satisfy
    pfn_valid(), so let's make that consistent across {read,write}_kem()
    too.
    Reported-by: default avatarKefeng Wang <wangkefeng.wang@huawei.com>
    Signed-off-by: default avatarRobin Murphy <robin.murphy@arm.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    148a1bc8
mem.c 19.1 KB