• Edward Cree's avatar
    ethtool: fix error handling in ethtool_phys_id · 2adc6edc
    Edward Cree authored
    If ops->set_phys_id() returned an error, previously we would only break
     out of the inner loop, which neither stopped the outer loop nor returned
     the error to the user (since 'rc' would be overwritten on the next pass
     through the loop).
    Thus, rewrite it to use a single loop, so that the break does the right
     thing.  Use u64 for 'count' and 'i' to prevent overflow in case of
     (unreasonably) large values of id.data and n.
    Signed-off-by: default avatarEdward Cree <ecree@solarflare.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    2adc6edc
ioctl.c 79.3 KB