• Tony Lindgren's avatar
    dmaengine: cppi41: Fix runtime PM timeouts with USB mass storage · 2c2e7fe7
    Tony Lindgren authored
    commit ae4a3e02 upstream.
    
    Commit fdea2d09 ("dmaengine: cppi41: Add basic PM runtime support")
    added runtime PM support for cppi41, but had corner case issues. Some of
    the issues were fixed with commit 098de42a ("dmaengine: cppi41: Fix
    unpaired pm runtime when only a USB hub is connected"). That fix however
    caused a new regression where we can get error -115 messages with USB on
    BeagleBone when connecting a USB mass storage device to a hub.
    
    This is because when connecting a USB mass storage device to a hub, the
    initial DMA transfers can take over 200ms to complete and cppi41
    autosuspend delay times out.
    
    To fix the issue, we want to implement refcounting for chan_busy array
    that contains the active dma transfers. Increasing the autosuspend delay
    won't help as that the delay could be potentially seconds, and it's best
    to let the USB subsystem to deal with the timeouts on errors.
    
    The earlier attempt for runtime PM was buggy as the pm_runtime_get/put()
    calls could get unpaired easily as they did not follow the state of
    the chan_busy array as described in commit 098de42a ("dmaengine:
    cppi41: Fix unpaired pm runtime when only a USB hub is connected".
    
    Let's fix the issue by adding pm_runtime_get() to where a new transfer
    is added to the chan_busy array, and calls to pm_runtime_put() where
    chan_busy array entry is cleared. This prevents any autosuspend timeouts
    from happening while dma transfers are active.
    
    Fixes: 098de42a ("dmaengine: cppi41: Fix unpaired pm runtime when
    only a USB hub is connected")
    Fixes: fdea2d09 ("dmaengine: cppi41: Add basic PM runtime support")
    Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
    Cc: Bin Liu <b-liu@ti.com>
    Cc: Grygorii Strashko <grygorii.strashko@ti.com>
    Cc: Kevin Hilman <khilman@baylibre.com>
    Cc: Patrick Titiano <ptitiano@baylibre.com>
    Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
    Signed-off-by: default avatarTony Lindgren <tony@atomide.com>
    Tested-by: default avatarBin Liu <b-liu@ti.com>
    Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    2c2e7fe7
cppi41.c 28.4 KB