• Darren Etheridge's avatar
    video: da8xx-fb: set upstream clock rate (if reqd) · 2dfa77a2
    Darren Etheridge authored
    Based on original patch by: Afzal Mohammed <afzal@ti.com>
    
    LCDC IP has a clock divider to adjust pixel clock, this limits pixel
    clock range to fck/255 - fck/2(fck - rate of input clock to LCDC IP).
    In the case of AM335x, where this IP is present, default fck is not
    sufficient to provide normal pixel clock rates, hence rendering this
    driver unusable on AM335x.
    
    If input clock too is configurable, allowable range of pixel clock
    would increase. Here initially it is checked whether with present fck,
    divider in IP could be configured to obtain required rate, if not,
    fck is adjusted. This makes it usable on AM335x.
    
    Note:
    Another solution would be to model an inherited basic clock divider of
    CCF, an advantage would be a better possible resolution for pixel clk.
    And trying to instantiate a CCF clock would mean that to be consistent,
    3 bits being turned on to enable clocks of LCDC IP would have to be
    modeled as gate clocks. Now that would bring in a total of 4 clocks,
    including necessity to create a new inherited divider clock, and that
    mean a branch of clock tree would be present in LCDC driver. This
    would add complexity to LCDC driver bringing in considerable amount
    of clock handling code, and this would not bring in much advantage
    for existing use cases other than providing a higher resolution of
    pixel clock. And existing use cases work without relying on clock
    modeling. Another fact is that out of the two platform's using this
    driver DaVinci is not yet converted to CCF. In future if higher
    resolution of pixel clock is required, and probably after DaVinci is
    CCF'ed, modeling clock nodes inside driver may be considered.
    
    v2: purely cosmetic changes to try and clarify what variables are
    	being used for in the clock rate / divider calculations
    Signed-off-by: default avatarDarren Etheridge <detheridge@ti.com>
    Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@ti.com>
    2dfa77a2
da8xx-fb.c 42 KB