• Arnaldo Carvalho de Melo's avatar
    perf hist: Don't fprintf the callgraph unconditionally · 3997d377
    Arnaldo Carvalho de Melo authored
    [root@doppio ~]# perf report -i newt.data | head -10
      # Samples: 11999679868
      #
      # Overhead  Command                  Shared Object  Symbol
      # ........  .......  .............................  ......
      #
          63.61%     perf  libslang.so.2.1.4              [.] SLsmg_write_chars
           6.30%     perf  perf                           [.] symbols__find
           2.19%     perf  libnewt.so.0.52.10             [.] newtListboxAppendEntry
           2.08%     perf  libslang.so.2.1.4              [.] SLsmg_write_chars@plt
           1.99%     perf  libc-2.10.2.so                 [.] _IO_vfprintf_internal
      [root@doppio ~]#
    
    Not good, the newt form for report works, but slang has to eat
    the cost of the additional callgraph lines everytime it prints a
    line, and the callgraph doesn't appear on the screen, so move
    the callgraph printing to a separate function and don't use it
    in newt.c.
    
    Newt tree widgets are being investigated to properly support
    callgraphs, but till that gets merged, lets remove this huge
    overhead and show at least the symbol overheads for a callgraph
    rich perf.data with good performance.
    Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Frédéric Weisbecker <fweisbec@gmail.com>
    Cc: Mike Galbraith <efault@gmx.de>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: Paul Mackerras <paulus@samba.org>
    LKML-Reference: <1268408808-13595-2-git-send-email-acme@infradead.org>
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
    3997d377
hist.c 14.4 KB