• Mark Rutland's avatar
    arm64: Survive invalid cpu enable-methods · 39a90ca6
    Mark Rutland authored
    Currently, if you pass the kernel a dtb where a cpu node has an
    unsupported enable-method property (e.g. "not-psci"), it'll explode
    horribly, as it iterates over the enable_ops array incorrectly. It
    increments the pointer *at* the current element, rather than
    incrementing the pointer *to* the current element. As the first two
    elements pointed to structures that were contiguous in memory, this
    happened to be equivalent. However the third element is NULL, so when
    the list is exhausted, smp_get_enable_ops generates the wrong pointer,
    and dereferences an arbitrary portion of memory, which currently happens
    to contain zero.
    
    This patch fixes this by indirecting the pointer one level, so we
    iterate over the array elements correctly, avoiding the below panic:
    Signed-off-by: default avatarMark Rutland <mark.rutland@arm.com>
    Signed-off-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
    39a90ca6
smp.c 12.7 KB