• Josh Boyer's avatar
    sony-laptop: Enable keyboard backlight by default · 3d58692d
    Josh Boyer authored
    commit 6fe6ae56 upstream.
    
    When the keyboard backlight support was originally added, the commit said
    to default it to on with a 10 second timeout.  That actually wasn't the
    case, as the default value is commented out for the kbd_backlight parameter.
    Because it is a static variable, it gets set to 0 by default without some
    other form of initialization.
    
    However, it seems the function to set the value wasn't actually called
    immediately, so whatever state the keyboard was in initially would remain.
    Then commit df410d52 was introduced during the 2.6.39 timeframe to
    immediately set whatever value was present (as well as attempt to
    restore/reset the state on module removal or resume).  That seems to have
    now forced the light off immediately when the module is loaded unless
    the option kbd_backlight=1 is specified.
    
    Let's enable it by default again (for the first time).  This should solve
    https://bugzilla.redhat.com/show_bug.cgi?id=728478Signed-off-by: default avatarJosh Boyer <jwboyer@redhat.com>
    Acked-by: default avatarMattia Dongili <malattia@linux.it>
    Signed-off-by: default avatarMatthew Garrett <mjg@redhat.com>
    Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
    3d58692d
sony-laptop.c 86.7 KB