• Russell King's avatar
    DMA-API: net: intel/ixgbe: fix 32-bit DMA mask handling · 40580423
    Russell King authored
    commit f5f2eda8 upstream.
    
    The fallback to 32-bit DMA mask is rather odd:
    	if (!dma_set_mask(&pdev->dev, DMA_BIT_MASK(64)) &&
    	    !dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(64))) {
    		pci_using_dac = 1;
    	} else {
    		err = dma_set_mask(&pdev->dev, DMA_BIT_MASK(32));
    		if (err) {
    			err = dma_set_coherent_mask(&pdev->dev,
    						    DMA_BIT_MASK(32));
    			if (err) {
    				dev_err(&pdev->dev,
    					"No usable DMA configuration, aborting\n");
    				goto err_dma;
    			}
    		}
    		pci_using_dac = 0;
    	}
    This means we only set the coherent DMA mask in the fallback path if
    the DMA mask set failed, which is silly.  This fixes it to set the
    coherent DMA mask only if dma_set_mask() succeeded, and to error out
    if either fails.
    Acked-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
    Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
    Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
    40580423
ixgbe_main.c 224 KB