• Boaz Harrosh's avatar
    pnfs-obj: Fix __r4w_get_page when offset is beyond i_size · 40606252
    Boaz Harrosh authored
    commit c999ff68 upstream.
    
    It is very common for the end of the file to be unaligned on
    stripe size. But since we know it's beyond file's end then
    the XOR should be preformed with all zeros.
    
    Old code used to just read zeros out of the OSD devices, which is a great
    waist. But what scares me more about this situation is that, we now have
    pages attached to the file's mapping that are beyond i_size. I don't
    like the kind of bugs this calls for.
    
    Fix both birds, by returning a global zero_page, if offset is beyond
    i_size.
    
    TODO:
    	Change the API to ->__r4w_get_page() so a NULL can be
    	returned without being considered as error, since XOR API
    	treats NULL entries as zero_pages.
    
    [Bug since 3.2. Should apply the same way to all Kernels since]
    Signed-off-by: default avatarBoaz Harrosh <bharrosh@panasas.com>
    [bwh: Backported to 3.2: adjust for lack of wdata->header]
    Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
    40606252
objio_osd.c 16.6 KB