• Trent Piepho's avatar
    V4L/DVB (6392): bttv: Update initial image size when set via V4L1 VIDIOCMCAPTURE · a8ab68bf
    Trent Piepho authored
    The V4L1 spec says that the image size should be with with VIDIOCSWIN before
    requesting buffers with VIDIOCGMBUF and capturing into them with
    VIDIOCMCAPTURE.
    
    But it seems that many apps don't do this.  They set the size using the fields
    in the VIDIOCMCAPTURE ioctl.  The driver doesn't know what size to capture
    until it actually starts to capture.  In particular, it doesn't know what size
    to capture until it has already mmap the captured buffers.  Which is quite
    stupid.  Why V4L1 has size and format fields for VIDIOCMCAPTURE I have no idea.
    
    Many drivers don't support this, including those using v4l1-compat.
    
    The bttv does, which is probably the only reason such broken software is so
    prevalent.
    
    But, the driver doesn't adjust its idea of what size is being captured when it
    is set this way.  If you try to query the driver's current setting with
    v4l2-ctl, it won't be correct.
    Signed-off-by: default avatarTrent Piepho <xyzzy@speakeasy.org>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@infradead.org>
    a8ab68bf
bttv-driver.c 127 KB