• Ben Widawsky's avatar
    drm/i915: Remove node only when allocated · 433544bd
    Ben Widawsky authored
    VMAs can be created and not bound. One may think of it as lazy cleanup,
    and safely gloss over the conditions which manufacture it. In either
    case, when the object backing the i915 vma is destroyed, we must cleanup
    the vma without stumbling into a bunch of pitfalls that assume the vma
    is bound.
    
    NOTE: I was pretty certain the above condition could only happen when we
    introduced the use of VMAs being looked up at execbuf, and already
    existing. Paulo has hit this though, so I must be missing something. As
    I believe the patch is correct anyway, therefore I won't scratch my head
    too hard.
    
    v2: use goto destroy as a compromise (Chris)
    
    Cc: Chris Wilson <chris@chris-wilson.co.uk>
    Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
    Signed-off-by: default avatarBen Widawsky <ben@bwidawsk.net>
    Reviewed-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
    Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
    433544bd
i915_gem.c 122 KB