• Bjorn Helgaas's avatar
    ixgbe: Report PCIe link properties with pcie_print_link_status() · 4695ca9d
    Bjorn Helgaas authored
    Previously the driver used pcie_get_minimum_link() to warn when the NIC
    is in a slot that can't supply as much bandwidth as the NIC could use.
    
    pcie_get_minimum_link() can be misleading because it finds the slowest link
    and the narrowest link (which may be different links) without considering
    the total bandwidth of each link.  For a path with a 16 GT/s x1 link and a
    2.5 GT/s x16 link, it returns 2.5 GT/s x1, which corresponds to 250 MB/s of
    bandwidth, not the true available bandwidth of about 1969 MB/s for a
    16 GT/s x1 link.
    
    Use pcie_print_link_status() to report PCIe link speed and possible
    limitations instead of implementing this in the driver itself.  This finds
    the slowest link in the path to the device by computing the total bandwidth
    of each link and compares that with the capabilities of the device.
    
    The dmesg change is:
    
      - PCI Express bandwidth of %dGT/s available
      - (Speed:%s, Width: x%d, Encoding Loss:%s)
      + %u.%03u Gb/s available PCIe bandwidth (%s x%d link)
    
    or, if the device is capable of better performance than is available in the
    current slot:
    
      - This is not sufficient for optimal performance of this card.
      - For optimal performance, at least %dGT/s of bandwidth is required.
      - A slot with more lanes and/or higher speed is suggested.
      + %u.%03u Gb/s available PCIe bandwidth, limited by %s x%d link at %s (capable of %u.%03u Gb/s with %s x%d link)
    
    Note that the driver previously used dev_warn() to suggest using a
    different slot, but pcie_print_link_status() uses dev_info() because if the
    platform has no faster slot available, the user can't do anything about the
    warning and may not want to be bothered with it.
    Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
    Acked-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
    4695ca9d
ixgbe_main.c 300 KB