• Shaohua Li's avatar
    vmscan: fix a livelock in kswapd · 4746efde
    Shaohua Li authored
    I'm running a workload which triggers a lot of swap in a machine with 4
    nodes.  After I kill the workload, I found a kswapd livelock.  Sometimes
    kswapd3 or kswapd2 are keeping running and I can't access filesystem,
    but most memory is free.
    
    This looks like a regression since commit 08951e54 ("mm: vmscan:
    correct check for kswapd sleeping in sleeping_prematurely").
    
    Node 2 and 3 have only ZONE_NORMAL, but balance_pgdat() will return 0
    for classzone_idx.  The reason is end_zone in balance_pgdat() is 0 by
    default, if all zones have watermark ok, end_zone will keep 0.
    
    Later sleeping_prematurely() always returns true.  Because this is an
    order 3 wakeup, and if classzone_idx is 0, both balanced_pages and
    present_pages in pgdat_balanced() are 0.  We add a special case here.
    If a zone has no page, we think it's balanced.  This fixes the livelock.
    Signed-off-by: default avatarShaohua Li <shaohua.li@intel.com>
    Acked-by: default avatarMel Gorman <mgorman@suse.de>
    Cc: Minchan Kim <minchan.kim@gmail.com>
    Cc: <stable@kernel.org>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    4746efde
vmscan.c 95.4 KB