• Marcel Ziswiler's avatar
    ARM: tegra: Fix ULPI regression on Tegra20 · 4c9a27a6
    Marcel Ziswiler authored
    Since commit f8f8f1d0 ("clk: Don't touch hardware when reparenting
    during registration") ULPI has been broken on Tegra20 leading to the
    following error message during boot:
    
    [    1.974698] ulpi_phy_power_on: ulpi write failed
    [    1.979384] tegra-ehci c5004000.usb: Failed to power on the phy
    [    1.985434] tegra-ehci: probe of c5004000.usb failed with error -110
    
    Debugging through the changes and finally also consulting the TRM
    revealed that rather than the CDEV2 clock off OSC requiring such pin
    muxing actually the PLL_P_OUT4 clock is in use. It looks like so far it
    just worked by chance of that one having been enabled which Stephen's
    commit now changed when reparenting sclk away from pll_p_out4 leaving
    that one disabled. Fix this by properly assigning the PLL_P_OUT4 clock
    as the ULPI PHY clock.
    Signed-off-by: default avatarMarcel Ziswiler <marcel.ziswiler@toradex.com>
    Reviewed-by: default avatarDmitry Osipenko <digetx@gmail.com>
    Reviewed-by: default avatarRob Herring <robh@kernel.org>
    Signed-off-by: default avatarThierry Reding <treding@nvidia.com>
    4c9a27a6
tegra20.dtsi 22.4 KB