• John Hubbard's avatar
    goldish_pipe: convert to pin_user_pages() and put_user_page() · 57459435
    John Hubbard authored
    1. Call the new global pin_user_pages_fast(), from
       pin_goldfish_pages().
    
    2. As required by pin_user_pages(), release these pages via
       put_user_page().  In this case, do so via put_user_pages_dirty_lock().
    
    That has the side effect of calling set_page_dirty_lock(), instead of
    set_page_dirty().  This is probably more accurate.
    
    As Christoph Hellwig put it, "set_page_dirty() is only safe if we are
    dealing with a file backed page where we have reference on the inode it
    hangs off." [1]
    
    Another side effect is that the release code is simplified because the
    page[] loop is now in gup.c instead of here, so just delete the local
    release_user_pages() entirely, and call put_user_pages_dirty_lock()
    directly, instead.
    
    [1] https://lore.kernel.org/r/20190723153640.GB720@lst.de
    
    Link: http://lkml.kernel.org/r/20200107224558.2362728-13-jhubbard@nvidia.comSigned-off-by: default avatarJohn Hubbard <jhubbard@nvidia.com>
    Reviewed-by: default avatarJan Kara <jack@suse.cz>
    Reviewed-by: default avatarIra Weiny <ira.weiny@intel.com>
    Cc: Alex Williamson <alex.williamson@redhat.com>
    Cc: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
    Cc: Björn Töpel <bjorn.topel@intel.com>
    Cc: Christoph Hellwig <hch@lst.de>
    Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
    Cc: Dan Williams <dan.j.williams@intel.com>
    Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>
    Cc: Jason Gunthorpe <jgg@mellanox.com>
    Cc: Jason Gunthorpe <jgg@ziepe.ca>
    Cc: Jens Axboe <axboe@kernel.dk>
    Cc: Jerome Glisse <jglisse@redhat.com>
    Cc: Jonathan Corbet <corbet@lwn.net>
    Cc: Kirill A. Shutemov <kirill@shutemov.name>
    Cc: Leon Romanovsky <leonro@mellanox.com>
    Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
    Cc: Mike Rapoport <rppt@linux.ibm.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    57459435
goldfish_pipe.c 26.3 KB