• Ard Biesheuvel's avatar
    efi/libstub/arm: Don't randomize runtime regions when CONFIG_HIBERNATION=y · 38fb6652
    Ard Biesheuvel authored
    Commit:
    
      e69176d6 ("ef/libstub/arm/arm64: Randomize the base of the UEFI rt services region")
    
    implemented randomization of the virtual mapping that the OS chooses for
    the UEFI runtime services. This was motivated by the fact that UEFI usually
    does not bother to specify any permission restrictions for those regions,
    making them prime real estate for exploitation now that the OS is getting
    more and more careful not to leave any R+W+X mapped regions lying around.
    
    However, this randomization breaks assumptions in the resume from
    hibernation code, which expects all memory regions populated by UEFI to
    remain in the same place, including their virtual mapping into the OS
    memory space. While this assumption may not be entirely reasonable in the
    first place, breaking it deliberately does not make a lot of sense either.
    So let's refrain from this randomization pass if CONFIG_HIBERNATION=y.
    Signed-off-by: default avatarArd Biesheuvel <ard.biesheuvel@linaro.org>
    Cc: James Morse <james.morse@arm.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Matt Fleming <matt@codeblueprint.co.uk>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: linux-efi@vger.kernel.org
    Link: http://lkml.kernel.org/r/20171025100448.26056-3-ard.biesheuvel@linaro.orgSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    38fb6652
arm-stub.c 12 KB