• Anders Roxell's avatar
    pinctrl: qcom: spmi-gpio: Mark expected switch fall-through · 6161dc03
    Anders Roxell authored
    When fall-through warnings was enabled by default the following warnings
    was starting to show up:
    
    ../drivers/pinctrl/qcom/pinctrl-spmi-gpio.c: In function ‘pmic_gpio_populate’:
    ../drivers/pinctrl/qcom/pinctrl-spmi-gpio.c:815:20: warning: this statement may fall
     through [-Wimplicit-fallthrough=]
       pad->have_buffer = true;
       ~~~~~~~~~~~~~~~~~^~~~~~
    ../drivers/pinctrl/qcom/pinctrl-spmi-gpio.c:816:2: note: here
      case PMIC_GPIO_SUBTYPE_GPIOC_4CH:
      ^~~~
    ../drivers/pinctrl/qcom/pinctrl-spmi-gpio.c:820:20: warning: this statement may fall
     through [-Wimplicit-fallthrough=]
       pad->have_buffer = true;
       ~~~~~~~~~~~~~~~~~^~~~~~
    ../drivers/pinctrl/qcom/pinctrl-spmi-gpio.c:821:2: note: here
      case PMIC_GPIO_SUBTYPE_GPIOC_8CH:
      ^~~~
    
    Rework so that the compiler doesn't warn about fall-through.
    
    Fixes: d93512ef0f0e ("Makefile: Globally enable fall-through warning")
    Signed-off-by: default avatarAnders Roxell <anders.roxell@linaro.org>
    Link: https://lore.kernel.org/r/20190726112816.19723-1-anders.roxell@linaro.orgSigned-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
    6161dc03
pinctrl-spmi-gpio.c 32.1 KB