• Jesper Juhl's avatar
    drivers/platform/x86/amilo-rfkill.c::amilo_rfkill_probe() avoid NULL deref · 41603e97
    Jesper Juhl authored
    In drivers/platform/x86/amilo-rfkill.c::amilo_rfkill_probe() the call
    to dmi_first_match() may fail and return NULL. If it does return NULL,
    then we'll be dereferencing a NULL pointer in the rfkill_alloc() call
    where we do 'system_id->driver_data' --> KABOOM!
    
    Avoid that problem by testing for a NULL return value from
    dmi_first_match() and bailing out if it fails.
    
    I was a bit uncertain about what to return in the failure case. In the
    end I settled for -ENXIO as the most logical error to return.
    Signed-off-by: default avatarJesper Juhl <jj@chaosbits.net>
    Signed-off-by: default avatarMatthew Garrett <mjg@redhat.com>
    41603e97
amilo-rfkill.c 4.15 KB