• Nathan Chancellor's avatar
    crypto: ccree - avoid implicit enum conversion · 18e732b8
    Nathan Chancellor authored
    Clang warns when one enumerated type is implicitly converted to another
    and this happens in several locations in this driver, ultimately related
    to the set_cipher_{mode,config0} functions. set_cipher_mode expects a mode
    of type drv_cipher_mode and set_cipher_config0 expects a mode of type
    drv_crypto_direction.
    
    drivers/crypto/ccree/cc_ivgen.c:58:35: warning: implicit conversion from
    enumeration type 'enum cc_desc_direction' to different enumeration type
    'enum drv_crypto_direction' [-Wenum-conversion]
            set_cipher_config0(&iv_seq[idx], DESC_DIRECTION_ENCRYPT_ENCRYPT);
    
    drivers/crypto/ccree/cc_hash.c:99:28: warning: implicit conversion from
    enumeration type 'enum cc_hash_conf_pad' to different enumeration type
    'enum drv_crypto_direction' [-Wenum-conversion]
                    set_cipher_config0(desc, HASH_DIGEST_RESULT_LITTLE_ENDIAN);
    
    drivers/crypto/ccree/cc_aead.c:1643:30: warning: implicit conversion
    from enumeration type 'enum drv_hash_hw_mode' to different enumeration
    type 'enum drv_cipher_mode' [-Wenum-conversion]
            set_cipher_mode(&desc[idx], DRV_HASH_HW_GHASH);
    
    Since this fundamentally isn't a problem because these values just
    represent simple integers for a shift operation, make it clear to Clang
    that this is okay by making the mode parameter in both functions an int.
    
    Link: https://github.com/ClangBuiltLinux/linux/issues/46Signed-off-by: default avatarNathan Chancellor <natechancellor@gmail.com>
    Acked-by: default avatarGilad Ben-Yossef <gilad@benyossef.com>
    Reviewed-by: default avatarNick Desaulniers <ndesaulniers@google.com>
    Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
    18e732b8
cc_hw_queue_defs.h 14.9 KB