• Stephen Boyd's avatar
    hwmon: (npcm750-pwm-fan) Remove dev_err() usage after platform_get_irq() · f2ff7cea
    Stephen Boyd authored
    We don't need dev_err() messages when platform_get_irq() fails now that
    platform_get_irq() prints an error message itself when something goes
    wrong. Let's remove these prints with a simple semantic patch.
    
    // <smpl>
    @@
    expression ret;
    struct platform_device *E;
    @@
    
    ret =
    (
    platform_get_irq(E, ...)
    |
    platform_get_irq_byname(E, ...)
    );
    
    if ( \( ret < 0 \| ret <= 0 \) )
    {
    (
    -if (ret != -EPROBE_DEFER)
    -{ ...
    -dev_err(...);
    -... }
    |
    ...
    -dev_err(...);
    )
    ...
    }
    // </smpl>
    
    While we're here, remove braces on if statements that only have one
    statement (manually).
    
    Cc: Jean Delvare <jdelvare@suse.com>
    Cc: Guenter Roeck <linux@roeck-us.net>
    Cc: linux-hwmon@vger.kernel.org
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: default avatarStephen Boyd <swboyd@chromium.org>
    [groeck: Dropped jz4740-hwmon.c (driver is being removed)]
    Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
    f2ff7cea
npcm750-pwm-fan.c 28.5 KB