• Hans de Goede's avatar
    virtio: console: Fix poll blocking even though there is data to read · 6df7aadc
    Hans de Goede authored
    I found this while working on a Linux agent for spice, the symptom I was
    seeing was select blocking on the spice vdagent virtio serial port even
    though there were messages queued up there.
    
    virtio_console's port_fops_poll checks port->inbuf != NULL to determine
    if read won't block. However if an application reads enough bytes from
    inbuf through port_fops_read, to empty the current port->inbuf,
    port->inbuf will be NULL even though there may be buffers left in the
    virtqueue.
    
    This causes poll() to block even though there is data to be read,
    this patch fixes this by using will_read_block(port) instead of the
    port->inbuf != NULL check.
    Signed-off-By: default avatarHans de Goede <hdegoede@redhat.com>
    Signed-off-by: default avatarAmit Shah <amit.shah@redhat.com>
    Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
    Cc: stable@kernel.org
    6df7aadc
virtio_console.c 39 KB