• Gustavo A. R. Silva's avatar
    media: sir_ir: remove unnecessary static in sir_interrupt() · 6efa0943
    Gustavo A. R. Silva authored
    Remove unnecessary static on local variable delt.
    Such variable is initialized before being used,
    on every execution path throughout the function.
    The static has no benefit and, removing it reduces
    the code size.
    
    This issue was detected using Coccinelle and the following semantic patch:
    
    @bad exists@
    position p;
    identifier x;
    type T;
    @@
    
    static T x@p;
    ...
    x = <+...x...+>
    
    @@
    identifier x;
    expression e;
    type T;
    position p != bad.p;
    @@
    
    -static
     T x@p;
     ... when != x
         when strict
    ?x = e;
    
    In the following log you can see the difference in the code size. Also,
    there is a significant difference in the bss segment. This log is the
    output of the size command, before and after the code change:
    
    before:
       text    data     bss     dec     hex filename
       5009    3456     576    9041    2351 drivers/media/rc/sir_ir.o
    
    after:
       text    data     bss     dec     hex filename
       4988    3400     512    8900    22c4 drivers/media/rc/sir_ir.o
    Signed-off-by: default avatarGustavo A. R. Silva <garsilva@embeddedor.com>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
    6efa0943
sir_ir.c 9.63 KB