• Theodore Ts'o's avatar
    ext4: Fix and simplify s_dirt handling · 7234ab2a
    Theodore Ts'o authored
    The s_dirt flag wasn't completely handled correctly, but it didn't
    really matter when journalling was enabled.  It turns out that when
    ext4 runs without a journal, we don't clear s_dirt in places where we
    should have, with the result that the high-level write_super()
    function was writing the superblock when it wasn't necessary.
    
    So we fix this by making ext4_commit_super() clear the s_dirt flag,
    and removing many of the other places where s_dirt is manipulated.
    When journalling is enabled, the s_dirt flag might be left set more
    often, but s_dirt really doesn't matter when journalling is enabled.
    Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
    7234ab2a
super.c 112 KB