• Jan Kara's avatar
    fsnotify: Avoid double locking in fsnotify_detach_from_object() · 73cd3c33
    Jan Kara authored
    We lock object list lock in fsnotify_detach_from_object() twice - once
    to detach mark and second time to recalculate mask. That is unnecessary
    and later it will become problematic as we will free the connector as
    soon as there is no mark in it. So move recalculation of fsnotify mask
    into the same critical section that is detaching mark.
    
    This also removes recalculation of child dentry flags from
    fsnotify_detach_from_object(). That is however fine. Those marks will
    get recalculated once some event happens on a child.
    Reviewed-by: default avatarMiklos Szeredi <mszeredi@redhat.com>
    Signed-off-by: default avatarJan Kara <jack@suse.cz>
    73cd3c33
mark.c 18.4 KB