• Julia Lawall's avatar
    Staging: rtl8192e: Drop unnecessary NULL test · 18526c78
    Julia Lawall authored
    The result of container_of should not be NULL.  In particular, in this case
    the argument to the enclosing function has passed though INIT_WORK, which
    dereferences it, implying that its container cannot be NULL.
    
    A simplified version of the semantic patch that makes this change is as
    follows:
    (http://www.emn.fr/x-info/coccinelle/)
    
    // <smpl>
    @@
    identifier fn,work,x,fld;
    type T;
    expression E1,E2;
    statement S;
    @@
    
    static fn(struct work_struct *work) {
      ... when != work = E1
      x = container_of(work,T,fld)
      ... when != x = E2
    - if (x == NULL) S
      ...
    }
    // </smpl>
    Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
    18526c78
r8192E_core.c 191 KB