• Stephan Baerwolf's avatar
    sched: Fix and optimise calculation of the weight-inverse · db670dac
    Stephan Baerwolf authored
    If the inverse loadweight should be zero, function "calc_delta_mine"
    calculates the inverse of "lw->weight" (in 32bit integer ops).
    
    This calculation is actually a little bit impure (because it is
    inverting something around "lw-weight"+1), especially when
    "lw->weight" becomes smaller.
    
    The correct inverse would be 1/lw->weight multiplied by
    "WMULT_CONST" for fixcomma-scaling it into integers.
    (So WMULT_CONST/lw->weight ...)
    
    The old, impure algorithm took two divisions for inverting lw->weight,
    the new, more exact one only takes one and an additional unlikely-if.
    Signed-off-by: default avatarStephan Baerwolf <stephan.baerwolf@tu-ilmenau.de>
    Signed-off-by: default avatarPeter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Link: http://lkml.kernel.org/n/tip-0pz0wnyalr4tk4ln11xwumdx@git.kernel.org
    [ This could explain some aritmetical issues for small shares but nothing
      concrete has been reported yet so we are not confident enough to queue
      this up in sched/urgent and for -stable backport. But if anyone finds
      this commit and sees it to fix some badness then we can certainly
      change our mind! ]
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
    db670dac
sched.c 218 KB