• Daniel Vetter's avatar
    drm/i915: revert pageflip/mappable related abi breakage · 818f2a3c
    Daniel Vetter authored
    In a00b10c3 "Only enforce fence limits inside the GTT"
    Chris Wilson implemented an optimization to only pin framebuffers
    as mappable for crtc_set_base (but not for pageflips). This breaks
    the abi, eg: A double buffering mesa client might leave the last
    framebuffer in unmappable space on close. A subsequent glReadPix
    by a frontbuffer rendering client then goes boom. My pretty anal
    mappable/unmappable consistency checking detected this, see
    
    https://bugs.freedesktop.org/show_bug.cgi?id=31286
    
    Chris Wilson tried to fix this in 085ce264 by pinning
    tiled framebuffers into mappable space. This
    a) renders the original optimization of not forcing framebuffers
       for pageflipping clients into mappable pointless because all our
       scanout buffers are tiled by default.
    b) doesn't solve the problem for untiled framebuffers.
    
    So kill this. Emperically it's no gain anyway because framebuffers are
    being reused by the ddx and hence there's no chance for them to get
    constanly bounced between mappable and unmappable.
    Signed-off-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
    Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
    818f2a3c
intel_display.c 177 KB