-
Li Shaohua authored
On Tuesday, August 31, 2004, Linus Torvalds wrote: > That list per se obviously looks ok by me, although I'd worry that some > other fs_initcall depends on the ACPI stuff having been run (ie while the > abover ordering is great, I worry that some _other_ part doesn't fit in > the above ordering). Doing a quick check finds "chr_dev_init()", for > example, which will do fbmem_init(), which might depend on the ACPI/PnP > stuff having run already. > > So it _might_ be safer to make this ordering more explicit, rather than Yes, I agree. The problem is there isn't a straightforward method for it. It possibly is hard to get it. > depending on the different phases of the initcalls. But I'd happily be > proven wrogn with some simple argument for why this is guaranteed to be > ok.. For example, maybe ACPI and PnP is linked before chr/mem.c, in which > case it should all be ok. Original PCI assign resources code is the last 'subsys_initcall' according to the makefile, so move some code of it to 'fs_initcall' (just below 'subsystem_initcall') should be ok. As you said, ACPI and PnP is linked before chr/mem.c. The method requires all other 'fs_initcall' don't touch PCI resources, since 'pcibios_assign_resources' is a 'fs_initcall' and maybe don't run, but it looks ok currently. Again, I will be appreciated if we can find a solution to make the ordering explicit. Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
8482ee7e