• Guenter Roeck's avatar
    serial: clps711x: Fix bad usage of IS_ERR_VALUE · 8f5405c9
    Guenter Roeck authored
    IS_ERR_VALUE() assumes that its parameter is an unsigned long.
    It can not be used to check if an unsigned int reflects an error.
    Doing so can result in the following build warning.
    
    drivers/tty/serial/clps711x.c: In function ‘uart_clps711x_probe’:
    include/linux/err.h:21:38: warning:
    	comparison is always false due to limited range of data type
    drivers/tty/serial/clps711x.c:471:6: note: in expansion of macro ‘IS_ERR_VALUE’
    
    If that warning is seen, an error return from platform_get_irq() is missed.
    
    Use a temporary variable to check for errors from platform_get_irq().
    Also don't use IS_ERR_VALUE() to check if an integer variable is < 0.
    The variable can be checked directly in that case.
    Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    8f5405c9
clps711x.c 14 KB