• Gerrit Renker's avatar
    [CCID2]: Disable broken Ack Ratio adaptation algorithm · 900bfed4
    Gerrit Renker authored
    This comments out a problematic section comprising a half-finished algorithm:
    
     - The variable `ccid2hctx_ackloss' is never initialised to a value different from 0 and
       hence in fact is a read-only constant.
     - The `arsent' variable counts packets other than Acks (it is incremented for every packet),
       and there is no test for Ack Loss.
     - The concept of counting Acks as such leads to a complex calculation, and the calculation
       at the moment is inconsistent with this concept.
       The problem is that the number of Acks - rather than the number of windows - is counted,
       which leads to a complex (cubic/quadratic) expression - this is not even implemented.
    
    In its current state, the commented-out algorithm interfers with normal processing by
    changing Ack Ratio incorrectly, and at the wrong times.
    
    A new algorithm is necessary, which will not necessarily use the same variables as used by
    the unfinished one; hence the old variables have been removed.
    Signed-off-by: default avatarGerrit Renker <gerrit@erg.abdn.ac.uk>
    Acked-by: default avatarIan McDonald <ian.mcdonald@jandi.co.nz>
    Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    900bfed4
ccid2.h 2.46 KB