• Dave Jones's avatar
    [CPUFREQ] Clean up convoluted code in arch/x86/kernel/tsc.c:time_cpufreq_notifier() · 931db6a3
    Dave Jones authored
    Christoph Hellwig noticed the following potential uninitialised use:
    
     > arch/x86/kernel/tsc.c: In function 'time_cpufreq_notifier':
     > arch/x86/kernel/tsc.c:634: warning: 'dummy' may be used uninitialized in this function
     >
     > where we do have CONFIG_SMP set, freq->flags & CPUFREQ_CONST_LOOPS is
     > true and ref_freq is false.
    
    It seems plausable, though the circumstances for hitting it are really low.
    Nearly all SMP capable cpufreq drivers set CPUFREQ_CONST_LOOPS.
    powernow-k8 is really the only exception. The older CPUs were typically
    only ever UP. (powernow-k7 never supported SMP for eg)
    
    It's worth fixing regardless, as it cleans up the code.
    
    Fix possible uninitialized use of dummy, by just removing it,
    and making the setting of lpj more obvious.
    Signed-off-by: default avatarDave Jones <davej@redhat.com>
    931db6a3
tsc.c 22.6 KB