• Amerigo Wang's avatar
    vfs: allow file truncations when both suid and write permissions set · 939a9421
    Amerigo Wang authored
    When suid is set and the non-owner user has write permission, any writing
    into this file should be allowed and suid should be removed after that.
    
    However, current kernel only allows writing without truncations, when we
    do truncations on that file, we get EPERM.  This is a bug.
    
    Steps to reproduce this bug:
    
    % ls -l rootdir/file1
    -rwsrwsrwx 1 root root 3 Jun 25 15:42 rootdir/file1
    % echo h > rootdir/file1
    zsh: operation not permitted: rootdir/file1
    % ls -l rootdir/file1
    -rwsrwsrwx 1 root root 3 Jun 25 15:42 rootdir/file1
    % echo h >> rootdir/file1
    % ls -l rootdir/file1
    -rwxrwxrwx 1 root root 5 Jun 25 16:34 rootdir/file1
    Signed-off-by: default avatarWANG Cong <amwang@redhat.com>
    Cc: Eric Sandeen <esandeen@redhat.com>
    Acked-by: default avatarEric Paris <eparis@redhat.com>
    Cc: Eugene Teo <eteo@redhat.com>
    Cc: Al Viro <viro@zeniv.linux.org.uk>
    Cc: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
    Cc: Christoph Hellwig <hch@lst.de>
    Cc: Stephen Smalley <sds@tycho.nsa.gov>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarJames Morris <jmorris@namei.org>
    939a9421
open.c 27 KB