• Jean Delvare's avatar
    USB: ohci-pnx4008: I2C cleanups and fixes · 64b3d6d1
    Jean Delvare authored
    Various cleanups and fixes to the i2c code in ohci-pnx4008:
    * Delete empty isp1301_command. The i2c driver command implementation
      is optional, so there's no point in providing an empty
      implementation.
    * Give a name to isp1301_driver. I'm surprised that i2c-core accepted
      to register this driver at all. I've chosen "isp1301_pnx" as the
      name, because it's not a generic ISP1301 driver (much like the
      isp1301_omap driver.) We might want to make the name even more
      specific (but "isp1301_ohci_pnx4008" doesn't fit.)
    * The ISP1301 is definitely not a hardware monitoring device.
    * Fix a memory leak on failure in isp1301_attach. If
      i2c_attach_client fails, the client is not registered so
      isp1301_detach is never called and the i2c_client memory is lost.
    * Use strlcpy instead of strcpy.
    Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
    Cc: Vitaly Wool <vitalywool@gmail.com>
    Cc: David Brownell <dbrownell@users.sourceforge.net>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
    64b3d6d1
ohci-pnx4008.c 11.5 KB