• Gustavo A. R. Silva's avatar
    ASoC: rsnd: remove unnecessary static in rsnd_ssiu_probe() · 32e1b60d
    Gustavo A. R. Silva authored
    Remove unnecessary static on local variable ops.
    Such variable is initialized before being used,
    on every execution path throughout the function.
    The static has no benefit and, removing it reduces
    the code size.
    
    This issue was detected using Coccinelle and the following semantic patch:
    
    @bad exists@
    position p;
    identifier x;
    type T;
    @@
    
    static T x@p;
    ...
    x = <+...x...+>
    
    @@
    identifier x;
    expression e;
    type T;
    position p != bad.p;
    @@
    
    -static
     T x@p;
     ... when != x
         when strict
    ?x = e;
    
    In the following log you can see the difference in the code size. Also,
    there is a significant difference in the bss segment. This log is the
    output of the size command, before and after the code change:
    
    before:
       text    data     bss     dec     hex filename
       3211     680      64    3955     f73 sound/soc/sh/rcar/ssiu.o
    
    after:
       text    data     bss     dec     hex filename
       3207     592       0    3799     ed7 sound/soc/sh/rcar/ssiu.o
    Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
    Signed-off-by: default avatarMark Brown <broonie@kernel.org>
    32e1b60d
ssiu.c 6.07 KB