• Arnd Bergmann's avatar
    swiotlb: fix phys_addr_t overflow warning · 9c106119
    Arnd Bergmann authored
    On architectures that have a larger dma_addr_t than phys_addr_t,
    the swiotlb_tbl_map_single() function truncates its return code
    in the failure path, making it impossible to identify the error
    later, as we compare to the original value:
    
    kernel/dma/swiotlb.c:551:9: error: implicit conversion from 'dma_addr_t' (aka 'unsigned long long') to 'phys_addr_t' (aka 'unsigned int') changes value from 18446744073709551615 to 4294967295 [-Werror,-Wconstant-conversion]
            return DMA_MAPPING_ERROR;
    
    Use an explicit typecast here to convert it to the narrower type,
    and use the same expression in the error handling later.
    
    Fixes: b907e205 ("swiotlb: remove SWIOTLB_MAP_ERROR")
    Acked-by: default avatarStefano Stabellini <sstabellini@kernel.org>
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Signed-off-by: default avatarKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    9c106119
swiotlb-xen.c 17.5 KB