• Joerg Roedel's avatar
    iommu/vt-d: Do deferred attachment in iommu_need_mapping() · a11bfde9
    Joerg Roedel authored
    The attachment of deferred devices needs to happen before the check
    whether the device is identity mapped or not. Otherwise the check will
    return wrong results, cause warnings boot failures in kdump kernels, like
    
    	WARNING: CPU: 0 PID: 318 at ../drivers/iommu/intel-iommu.c:592 domain_get_iommu+0x61/0x70
    
    	[...]
    
    	 Call Trace:
    	  __intel_map_single+0x55/0x190
    	  intel_alloc_coherent+0xac/0x110
    	  dmam_alloc_attrs+0x50/0xa0
    	  ahci_port_start+0xfb/0x1f0 [libahci]
    	  ata_host_start.part.39+0x104/0x1e0 [libata]
    
    With the earlier check the kdump boot succeeds and a crashdump is written.
    
    Fixes: 1ee0186b ("iommu/vt-d: Refactor find_domain() helper")
    Cc: stable@vger.kernel.org # v5.5
    Reviewed-by: default avatarJerry Snitselaar <jsnitsel@redhat.com>
    Acked-by: default avatarLu Baolu <baolu.lu@linux.intel.com>
    Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
    a11bfde9
intel-iommu.c 160 KB